Update packages to latest versions #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robford123 why did you add <ItemGroup>
<PackageReference Update="xunit.runner.visualstudio">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
</PackageReference>
</ItemGroup>in many csproj? |
|
Upgrading the packages automatically added that in, I checked it built and tests ran ok. |
|
LoL I didn't know that Visual Studios test discovery isn't that good, so the packages is almost required when using Visual Studio. |
|
@robford123 Can you have a look into the merge conflicts? |
Signed-off-by: Rob Ford <[email protected]>
|
@seriouz should be all good now |
seriouz
approved these changes
Sep 7, 2024
It should actually be in the Directory.Build.props of the test directory, not sure why it was added to the individual project files again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all packages to latest versions. Removes some vulnerabilities, especially in the Postgres libraries.